Repository navigation
docs: remove nonexistent "All devices" filter option - #6114
Merged
Merged
Conversation
The Device filter renders exactly two things: a This device item, and an Other devices group listing each opted-in remote host by name with an online indicator (V2WorkspacesHeader.tsx:201-225). There is no All devices option -- the string does not appear anywhere in apps/desktop/src. Found while triaging #6047.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe remote workspace documentation now lists remote hosts only under Other devices. The redundant All devices option is removed. ChangesRemote workspace documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
4 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remote-workspaces.mdxdocuments an All devices option in the Workspaces Device filter. That option does not exist —git grep "All devices" apps/desktop/srcreturns nothing.The picker actually renders a This device item plus an Other devices group listing each opted-in remote host by name with an online indicator (
V2WorkspacesHeader.tsx:201-225). Users following the docs would look for a control that was never built.Test plan
origin/main: zero occurrences ofAll devicesinapps/desktop/src; onlyDEVICE_FILTER_THIS_DEVICEplus per-host ids existbun run lintexits 0Found while triaging #6047, the last output of the now-removed
update-docs.ymlworkflow. The rest of that PR's salvageable content (terminals list/send/read/closein the CLI and SDK references, plus five short feature notes) is not included here and still needs a separate pass.Summary by CodeRabbit